fix(nix): disable filterpy tests on Darwin to avoid pytest BPT trap#22
Merged
jamesbrink merged 1 commit intoutensils:mainfrom Jan 26, 2026
Merged
fix(nix): disable filterpy tests on Darwin to avoid pytest BPT trap#22jamesbrink merged 1 commit intoutensils:mainfrom
jamesbrink merged 1 commit intoutensils:mainfrom
Conversation
Member
|
Sorry for the delay, I am reviewing this today! |
Member
|
Thanks for the fix, @Kyure-A! 🙏 I've verified this is a real issue - the Hydra build history for filterpy on aarch64-darwin shows multiple failures. The BPT trap during The fix looks good - disabling tests only on Darwin while preserving them on Linux is the right approach. This is a common pattern in nixpkgs for handling platform-specific test failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The following error occurred on Darwin.
Changes
Override
filterpyto setdoCheck = falseonly on Darwin.